RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

[Simon Tooke]

On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Trivial change to drop the optimization level (for both fastdebug and release) of stackMapTable.cpp to O1 on MacOS with Xcode 16.
> 
> This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which prevents building on MacOS.
> 
> Tested: with patch fastdebug and release builds are green again.

(disclaimer: I am not a reviewer)

This is not the first time OpenJDK has had to disable optimization on specific files, and it won't be the last time.
Not addressing this issue risks running into the problems encountered with JDK8 at one time - you had to run XCode 4 in a VM to compile the thing, due to bit rot.  (I had a repo containing a collection of patches like this one; it was my most starred.)

I realize that these exceptions require revisiting now and then, that is the downside.

I would love it if this made it in, at least for now.  It would certainly save developers some time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21119#issuecomment-2474638064