RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

[Julian Waters]

On Thu, 14 Nov 2024 14:08:39 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> My experience is quite different.  As I've said previously, I'm not getting anywhere near through a build
>> with gcc13.2.  As far as I can tell, building with LTO is quite badly broken.  It's bad enough, and other
>> runtime issues seem nasty enough to me, that I'm giving up on following this.  We have gotten a couple
>> of good bug fixes out of it, but for the rest...
>
> I switched from my standard gcc 11.3.0 devkit to 13.2.1; build works nicely with it and  jtreg HS :tier1 results look similar to what I get with gcc 11.3.0.
> I still get 90 of those ugly  `warning: call to ‘vsnprintf’ declared with attribute warning: use os::vsnprintf`   [-Wattribute-warning] ;  maybe we should disable the attribute warnings for the lto build ?
> 
> One thing I maybe have to add - I currently do not build the lto build with gtest (--with-gtest was removed from my script).

Yes, I think it's an acceptable workaround to disable attribute-warning (It's one of the solutions I mentioned earlier, but I'm guessing you mean more aggressively). LTO is not the typical way of compiling HotSpot, so this shouldn't be a problem, until LTO becomes viable enough that it becomes the standard, but that's probably going to be a long time in the future

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22069#discussion_r1843210022