RFR: 8342836: Automatically determine that a test in the docs test root is requested
Erik Joelsson
erikj at openjdk.org
Tue Nov 19 19:03:12 UTC 2024
On Tue, 19 Nov 2024 14:23:30 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> Please review this patch to automatically set `TEST_DEPS` to `docs-jdk` when testing the documentation.
>
> This comes as a followup to https://github.com/openjdk/jdk/commit/07f550b85a3910edd28d8761e2adfb8d6a1352f6 , as review comments suggested better aways of adding dependencies and to not require users to use a verbose `make test TEST=docs_all TEST_DEPS=docs-jdk`.
>
> I have verified that `make test-docs_all` does indeed build the docs, `make test TEST=docs_all` does not but the former is clear and short enough to be used.
>
> TIA.
I think this looks ok, but I would like to let Magnus weigh in too.
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22239#pullrequestreview-2446346352
More information about the build-dev
mailing list