RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]
Erik Joelsson
erikj at openjdk.org
Tue Nov 19 23:11:19 UTC 2024
On Tue, 19 Nov 2024 22:50:37 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> With this change, the compact object headers related CDS archives (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by default. If the user needs them, the user can specify the `--enable-cds-archive-coh=yes` build configure option.
>> This change also modified the TestDefaultArchiveLoading.java test.
>>
>> Testing:
>>
>> - default build config: classes*coh.jsa CDS archives are not generated
>> - build configured with `--enable-cds-archive-coh=yes`: classes*coh.jsa CDS archives are generated
>> - build configured with `--enable-cds-archive-coh=no`: classes*coh.jsa CDS archives are not generated
>> - passed tiers 1 and 3 tests
>>
>> Update:
>>
>> The classes*coh.jsa archives will be generated by default. In case the user doesn't want to generate those archives, just specify the --disable-cds-archive-coh option in the build configure command.
>
> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Erik's comment
> - Merge branch 'master' into 8341533-remove-coh-CDS-archives
> - @iklam comment
> - 8341553: Remove UseCompactObjectHeaders extra CDS archives
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/22051#pullrequestreview-2446829973
More information about the build-dev
mailing list