RFR: 8344093: Implement JEP 501: Deprecate the 32-bit x86 Port for Removal [v4]
David Holmes
dholmes at openjdk.org
Tue Nov 26 00:42:42 UTC 2024
On Mon, 25 Nov 2024 09:36:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> WIP, as the JEP is still not targeted. We can review code meanwhile.
>>
>> Additional testing:
>> - [x] Linux x86-32 build configure fails by default
>> - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes`
>> - [x] GHA
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8344093-x86-32-deprecation
> - Merge branch 'master' into JDK-8344093-x86-32-deprecation
> - Merge branch 'master' into JDK-8344093-x86-32-deprecation
> - Initial work
make/autoconf/platform.m4 line 673:
> 671: AC_MSG_WARN([The x86 port is deprecated and may be removed in a future release.])
> 672: else
> 673: AC_MSG_ERROR(m4_normalize([The 32-bit x86 port is deprecated and may be removed in a future release.
Shouldn't this wording be the same in both cases?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22062#discussion_r1857515376
More information about the build-dev
mailing list