RFR: 8344093: Implement JEP 501: Deprecate the 32-bit x86 Port for Removal [v5]
Volker Simonis
simonis at openjdk.org
Tue Nov 26 20:00:49 UTC 2024
On Tue, 26 Nov 2024 09:48:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> WIP, as the JEP is still not targeted. We can review code meanwhile.
>>
>> Additional testing:
>> - [x] Linux x86-32 build configure fails by default
>> - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes`
>> - [x] GHA
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Sync warning messages
Looks good in general. Maybe add a warning to `doc/building.md` that the linux-x86 build is now deprecated. You can actually retrofit the warning that was [added for the windows-86 build deprecation](https://github.com/openjdk/jdk/commit/29b8d3d9e73c3771f18b8d4d69e32475f17346fa) now that windows-x86 has been removed.
I'm also not sure about who's using `make/conf/jib-profiles.js` but when I look at it's commit history, it still seems to be supported. That probably needs some update too. I.e. remove the `windows-x86` configurations (not related to this change) and add the `--enable-deprecated-ports` configure options to the `linux-x86` and `linux-x64-zero` profiles.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22062#issuecomment-2501806183
More information about the build-dev
mailing list