RFR: 8340818: Add a new jtreg test root to test the generated documentation [v3]

[Erik Joelsson]

On Thu, 10 Oct 2024 00:16:40 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Please review this change that adds a new test root `docs` dedicated to testing the documentation, which has been a work in progress for a while. Tests for links, encoding, HTML, accessibility will be later added in following PRs. 
>> 
>> We also define a new make target `test-docs` meant for local use and depends on the docs.
>> This also adds the necessary configurations needed at Oracle.
>> 
>> This patch includes a test `TestDocs` which serves to show developers how they are meant to resolve the docs to test them, I want to include it temporarily until better tests are added later.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   typos - remove a few mentions of doccheck

make/conf/jib-profiles.js line 1004:

> 1002:     var testOnlyProfilesPrebuiltDocs = clone(testOnlyProfilesPrebuilt);
> 1003:     testOnlyProfilesPrebuiltDocs["run-test-prebuilt-docs"] = testOnlyProfilesPrebuiltDocs["run-test-prebuilt"];
> 1004:     delete testOnlyProfilesPrebuiltDocs["run-test-prebuilt"];

I think this could be simplified to something like (untested):
Suggestion:

    var testOnlyProfilesPrebuiltDocs = {};
    testOnlyProfilesPrebuiltDocs["run-test-prebuilt-docs"] = clone(testOnlyProfilesPrebuiltDocs["run-test-prebuilt"]);

make/conf/jib-profiles.js line 1048:

> 1046:         }
> 1047:         profiles["run-test"] = concatObjects(profiles["run-test"], windowsRunTestExtra);
> 1048:         profiles["run-test-prebuilt"] = concatObjects(profiles["run-test-prebuilt"], windowsRunTestExtra);

What happened to all of this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1795892528
PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1795898544