RFR: 8339570: Add Tidy build support for JDK tests [v8]

[Nizar Benalla]

On Tue, 15 Oct 2024 17:43:17 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove check in RunTests.gmk, different approach.
>>   Remove environment_name TIDY_HOME
>
> make/RunTestsPrebuiltSpec.gmk line 182:
> 
>> 180: ifneq ($(TIDY_HOME), )
>> 181:   TIDY := $(TIDY_HOME)/bin/tidy
>> 182: endif
> 
> Unless TIDY_HOME is a well established variable in the context of Tidy, which I doubt, then I think this isn't needed anymore. We aren't setting this from jib-profiles.js, and I can't think of any other place this would be set. We should export `TIDY` as an environment variable in the `run-test-prebuilt-docs` profile in the other PR though.

I need to push one more patch in the other PR for these to be in sync but `TIDY_HOME` is needed.

`RunTestsPrebuiltSpec.gmk` is only read if you use `make run-test-prebuilt`, without running configure. (I'm stealing Magnus' words here)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1801667822