RFR: 8339570: Add Tidy build support for JDK tests [v10]

[Erik Joelsson]

On Tue, 15 Oct 2024 17:57:59 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I get a review for this patch that adds the necessary changes for local support of the `tidy` library.
>> 
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` on Linux and MacOs systems.
>> 
>> This dependency is primarily going to be used to test the generated documentation.
>> 
>> This patch is meant to be integrated before #21272.
>> 
>> Note: we need to be a very specific revision of `tidy` and cannot use any of the available artifacts, as older versions do not recognize some HTML 5 elements. 
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace

make/RunTestsPrebuiltSpec.gmk line 182:

> 180: ifneq ($(TIDY_HOME), )
> 181:   TIDY := $(TIDY_HOME)
> 182: endif

This is worse than before. Please forget what I said initially about `TIDY_HOME`, it should certainly not be used as an alias for `TIDY`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1801674388