RFR: 8339570: Add Tidy build support for JDK tests [v10]

[Erik Joelsson]

On Tue, 15 Oct 2024 18:46:55 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> make/RunTestsPrebuiltSpec.gmk line 182:
>> 
>>> 180: ifneq ($(TIDY_HOME), )
>>> 181:   TIDY := $(TIDY_HOME)
>>> 182: endif
>> 
>> This is worse than before. Please forget what I said initially about `TIDY_HOME`, it should certainly not be used as an alias for `TIDY`.
>
> I may need suggestions, I pushed the last changes to the other PR [f5aeddd](https://github.com/openjdk/jdk/pull/21272/commits/f5aeddd8a2b142934558d75b5b81823ddeefd6e0).
> 
> I need a way to set `TIDY` without using configure, so that `-Dtidy` is set in RunTests.gmk.
> 
> Maybe I can change `testOnlyProfilesPrebuiltDocs["run-test-prebuilt-docs"].environment["TIDY_HOME"] = input.get("tidy", "home_path") + "/bin/tidy";` to use `TIDY` instead of `TIDY_HOME`? There would be no conflict as configure is not run and `TIDY=` was never passed.
> 
> That was I drop the changes in `RunTestsPrebuiltSpec.gmk` and only keep those in `RunTests.gmk`

That is exactly what I would like you to do.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1801807774