RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]
Ludovic Henry
luhenry at openjdk.org
Wed Oct 16 12:18:11 UTC 2024
On Wed, 16 Oct 2024 10:29:58 GMT, Fei Gao <fgao at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update make/autoconf/flags-cflags.m4
>>
>> Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8218:
>
>> 8216:
>> 8217: snprintf(ebuf, sizeof(ebuf), "%sdx_%ssve", VectorSupport::mathname[op], ulf);
>> 8218: StubRoutines::_vector_d_math[VectorSupport::VEC_SIZE_SCALABLE][op] = (address)os::dll_lookup(libsleef, ebuf);
>
> May I ask why `aarch64` doesn't have C file including macro expansion of function names while `RISC-V` needs it, see added in https://github.com/openjdk/jdk/pull/21083/files#diff-65f5198005719e644115782e7f4dd5a17c0969b01cbb50a1224b6800bbf8f177? Thanks.
Agreed, it seems to be missing `src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_sve.c` in this PR
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21502#discussion_r1802992418
More information about the build-dev
mailing list