RFR: 8339570: Add Tidy build support for JDK tests [v11]

[Magnus Ihse Bursie]

On Wed, 16 Oct 2024 18:42:38 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes to RunTestsPrebuiltSpec.gmk
>
> make/autoconf/lib-tests.m4 line 330:
> 
>> 328:       AC_MSG_RESULT([yes])
>> 329:       AC_MSG_CHECKING([for tidy version])
>> 330:       TIDY_VERSION=`$ECHO $tidy_output | $SED -e 's/.*version //g'`
> 
> Looks like `TIDY_VERSION` isn't "exported", should it be lower-case?

We're not really consistant on that usage. In fact, I'd say that most variables are upper case, regardless of how "local" their use is, and the lower case variant is a minority. So I'd say it's up to Nizar; if he wants to change this he can, otherwise it can stay upper case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1804968695