RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]
Sean Mullan
mullan at openjdk.org
Tue Oct 22 15:28:37 UTC 2024
On Tue, 22 Oct 2024 08:09:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to deprecated annotation on checkAccess methods. Change method dedescription to "Does nothing".
>> - Sanitize the class descriptions of DelegationPermission and ServicePermission
>> by removing text that refers to granting permissions, but avoid changes that
>> affect the API specification, such as the description and format of input
>> parameters.
>> - Restored methods in RMIConnection to throw SecurityExceptions again but
>> with adjusted text that avoids the word "permission".
>> - Add text to class description of MBeanServer stating that implementations
>> may throw SecurityException if authorization doesn't allow access to resource.
>> - Restore text about needing permissions from the desktop environment in the
>> getPixelColor and createScreenCapture methods.
>> - Add api note to getClassContext to use StackWalker instead and
>> add DROP_METHOD_INFO option to StackWalker.
>> - Change checkAccess() methods to be no-ops, rather than throwing
>> SecurityException.
>> - Merge
>> - Merge
>> - ... and 87 more: https://git.openjdk.org/jdk/compare/f50bd0d9...f89d9d09
>
> test/jdk/javax/swing/JComboBox/8080972/TestBasicComboBoxEditor.java line 26:
>
>> 24: import javax.swing.SwingUtilities;
>> 25: import javax.swing.plaf.basic.BasicComboBoxEditor;
>> 26: /*
>
> I think we have finally decided that jtreg tag will come after copyright and before imports...Applicable for all modified javax_swing tests in this PR...
This should be addressed in a more general separate task, and not part of this PR since it does not have anything to do with the changes in this JEP.
> test/jdk/javax/swing/JOptionPane/8081019/bug8081019.java line 31:
>
>> 29: /**
>> 30: * @test
>> 31: * @key headful
>
> javadoc style /** at the beginning
Not specific to JEP 486, this should be done as part of a different issue.
> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 66:
>
>> 64: }
>> 65:
>> 66: // Show popup as if from an applet
>
> remove applet
Not specific to JEP 486, this should be done as part of a different issue.
> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 29:
>
>> 27: * @test
>> 28: * @bug 6622002
>> 29: * @author Alexander Potochkin
>
> remove @author tag
Not specific to JEP 486, this should be done as part of a different issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1810939227
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1810942471
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1810943153
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1810943359
More information about the build-dev
mailing list