RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Harshitha Onkar
honkar at openjdk.org
Thu Oct 24 18:12:41 UTC 2024
On Thu, 24 Oct 2024 14:55:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Update @summary to replace "if the right permission is granted" can be replaced with "package java.lang is open to unnamed module".
>> - Remove println about Security Manager.
>> - Remove unused static variable NEW_PROXY_IN_PKG.
>> - Remove static variable `DEFAULT_POLICY` and unused imports.
>> - Remove hasSM() method and code that calls it, and remove comment about
>> running test manually with SM.
>> - clientlibs: import order
>> - warning-string
>> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: integrated review feedback in renamed WSSanityTest.java
>> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde
>
> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>
>> 711: * {@code Info.plist}.
>> 712: *
>> 713: * @param printFileHandler handler
>
> Suggestion:
>
> * @param printFileHandler handler
> *
>
> Can we add a blank line here? It's present in the methods above.
>
> Although there are other places below where it's missing; so not worth worrying.
@seanjmullan Can you please advice on some of these src file javadoc related clean-up review comments. Do they need to be handled in this PR? Some of them seem out-of-scope for jep486 PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1815510916
More information about the build-dev
mailing list