RFR: 8335880: More troubleshooting tips around windows space in path [v5]

Magnus Ihse Bursie ihse at openjdk.org
Thu Oct 24 18:42:05 UTC 2024


On Tue, 22 Oct 2024 14:55:47 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html
>> 
>> People were confused on a few details around fixing windows space names, including:
>> 1. setshortname can report confusing error message when the directory is in use
>> 2. Many directories can have names set but only Microsoft Visual Studio and Windows Kits need them
>> 
>> Also adds some notes about `jdk` being the exploded image while `images/jdk` is the actual image.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rollback missed change, give an example of ignorable warning

Looks good, thanks for fixing!

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20197#pullrequestreview-2393457695


More information about the build-dev mailing list