RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v4]
Sean Mullan
mullan at openjdk.org
Mon Oct 28 14:26:45 UTC 2024
On Fri, 25 Oct 2024 21:02:37 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> src/java.base/share/classes/java/security/Policy.java line 90:
>>
>>> 88: * and subject to removal in a future release. Consequently, this class
>>> 89: * is also deprecated and subject to removal. There is no replacement for
>>> 90: * the Security Manager or this class.
>>
>> Don't you need at least one sentence as the body of the class spec here? Something like `Policy was...` which is similar to `AccessController`.
>
> Yes, we should be consistent. The deprecated text always comes first, and sometimes we want to say immediately why this class is not useful anymore in that text instead of later, further down. I don't know which is better. I guess I'll go with your suggestion just so it looks more like a normal class.
Fixed in https://github.com/openjdk/jdk/pull/21498/commits/09b6cd602c1f2c7998ed824878c5f5f43be69075
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1819163498
More information about the build-dev
mailing list