RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

[Sean Mullan]

On Fri, 25 Oct 2024 19:55:33 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Sean Mullan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 150 commits:
>> 
>>  - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>>  - Merge
>>  - Update @summary to replace "if the right permission is granted" can be replaced with "package java.lang is open to unnamed module".
>>  - Remove println about Security Manager.
>>  - Remove unused static variable NEW_PROXY_IN_PKG.
>>  - Remove static variable `DEFAULT_POLICY` and unused imports.
>>  - Remove hasSM() method and code that calls it, and remove comment about
>>    running test manually with SM.
>>  - clientlibs: import order
>>  - warning-string
>>  - java/net/httpclient/websocket/security/WSURLPermissionTest.java: integrated review feedback in renamed WSSanityTest.java
>>  - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde
>
> test/jdk/java/util/PluggableLocale/PermissionTest.java line 52:
> 
>> 50: import com.foo.NumberFormatProviderImpl;
>> 51: 
>> 52: public class PermissionTest{
> 
> This test can be deleted entirely. What remains is just constructing each provider impl.
> The summary mentions a RuntimePermission and would need to be revised to a new description.

Fixed in https://github.com/openjdk/jdk/pull/21498/commits/8054d108fea3ce9e7f1618c3d90ef5af6cfa22d7

> test/jdk/java/util/logging/FileHandlerLongLimit.java line 157:
> 
>> 155:     static class Configure {
>> 156:         static void setUp(Properties propertyFile) {
>> 157:             doPrivileged(() -> {
> 
> The doPrivileged() could be factored out.
> And callPrivileged().

These are all fixed in https://github.com/openjdk/jdk/pull/21498/commits/bc5b3d70741505a684a39474630372a9b2fd8bc0

> test/jdk/java/util/logging/TestLogConfigurationDeadLockWithConf.java line 83:
> 
>> 81:      * then the test is considered a success and passes.
>> 82:      *
>> 83:      * Note that 4sec may not be enough to detect issues if there are some.
> 
> Where is this timeout enforced or measured; this is just a comment, not a parameter.

Fixed in https://github.com/openjdk/jdk/pull/21498/commits/2a9b98e244362dbbb98487098865cfd46a46dc1e

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820722883
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820727624
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1820725397