RFR: 8339783: Implementation of JEP 479: Remove the Windows 32-bit x86 Port [v3]

[Aleksey Shipilev]

On Tue, 29 Oct 2024 13:26:57 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 523:
>> 
>>> 521: 
>>> 522: extern "C" int SpinPause () {
>>> 523: #ifdef AMD64
>> 
>> Weird that SpinPause is not implemented on Win64, but oh well. This whole SpinPause mess should be arch-specific, not OS/Arch specific, probably.
>
> @shipilev There _is_ a way to implement SpinPause on Windows/x64 though, if support is really as simple as a single pause instruction. Should I help implement this separately (After this PR is integrated, to avoid conflicts)? Although, the way SpinPause can be implemented is honestly so simple and trivial that @magicus could simply replace the entire body of this SpinPause with it in this PR

Submit a separate PR and implement this :) Pretty sure you'll get into some dark territories in Windows/AArch64, see how Linux/AArch64 does this. But honestly, this whole `extern "C"` mess should probably be cleaned up in favor of arch-specific stubs or something like that...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1820935020