RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v12]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Oct 30 11:13:52 UTC 2024
On Wed, 30 Oct 2024 00:07:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> adlc need _CRT_NONSTDC_NO_WARNINGS as well... *sigh*
>
> src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp line 1433:
>
>> 1431:
>> 1432: int stack_size = stack_slots * VMRegImpl::stack_slot_size;
>> 1433:
>
> I think it might be better to keep this comment. It might be helpful information for someone who
> needs to touch this code between now and when we remove all 32bit x86 support (which might
> be soonish, but not immediate). And this comment will go away when that change happens.
Ok.
Many of these changes were made in the jdk-sandbox before the JEP to deprecate all 32-bit x86 code was created, and in that perspective, it made more sense to actually properly clean out the Windows things from the x86 code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822396126
More information about the build-dev
mailing list