RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v15]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Oct 30 11:31:17 UTC 2024
On Wed, 30 Oct 2024 03:24:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> src/java.base/windows/native/libjava/gdefs_md.h line 31:
>
>> 29:
>> 30: #include <stddef.h>
>> 31: #ifndef _WIN64
>
> I suspect the unix/windows gdefs_md.h files could be eliminated, and just make gdefs.h use portable
> headers. That can be done as a separate cleanup.
Good point. I created https://bugs.openjdk.org/browse/JDK-8343291.
> src/java.base/windows/native/libjava/jlong_md.h line 66:
>
>> 64: #define jlong_zero_init ((jlong) 0)
>> 65:
>> 66: #ifdef _WIN64
>
> After this change I think the differences between the unix and windows variants of this file are trivial
> and could be resolved in favor of moving everything directly into jlong.h. Though note there are some
> places in java.desktop that currently directly include jlong_md.h. This can be done as a separate cleanup.
Right. I updated JDK-8343291 to cover this case as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822420044
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822422712
More information about the build-dev
mailing list