RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v40]

Mandy Chung mchung at openjdk.org
Thu Oct 31 18:43:58 UTC 2024


On Thu, 31 Oct 2024 10:24:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I've changed it to AssertionError, but can change it to UncheckedIOException instead. Will take another pass on this issue tomorrow.
>
> Having looked at this again the patch now consistently uses `AssertionError` which should be fine? Please let me know if that's an issue.

I prefer `UncheckedIOException` as it clearly shows related to I/O which could happen due to interrupted I/O  operations.  

`AssertionError` should never happen or a bug in the implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1824947617


More information about the build-dev mailing list