RFR: 8338916: Build warnings about overriding recipe for jvm-ldflags.txt

[Magnus Ihse Bursie]

On Mon, 2 Sep 2024 12:28:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> From the bug report:
> 
> Users are reporting warnings like this:
> 
> lib/CompileGtest.gmk:84: warning: overriding recipe for target '/.../build/linux-x64/make-support/compile-commands/jvm-ldflags.txt'
> lib/CompileJvm.gmk:166: warning: ignoring old recipe for target '/.../build/linux-x64/make-support/compile-commands/jvm-ldflags.txt'
> 
> I believe this is caused by [JDK-8338290](https://bugs.openjdk.org/browse/JDK-8338290), where the jvm-ldflags.txt target file isn't made unique enough.

No, it is a "local" variable. We use the `$1_` syntax to get namespaced variables. These can be used either as input (or output!) arguments to a function, or as internal helper variables. The one I added falls into the latter category.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20819#issuecomment-2324657733