Integrated: 8339336: Fix build system whitespace to adhere to coding conventions

Magnus Ihse Bursie ihse at openjdk.org
Tue Sep 3 15:34:30 UTC 2024


On Fri, 30 Aug 2024 16:27:18 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The build system code has unfortunately diverted in some places from the conventions as described in https://openjdk.org/groups/build/doc/code-conventions.html.
> 
> Instead of trying to fix these when touching code nearby, I'd like to make an effort to fix all issues at once and separately. Incremental fixes has their benefit, but they can also muddy the actual fix and are not always appreciated.
> 
> The updates in this patch have all been discovered using automated tools, but each and every change has been manually scrutinized. Those that the automatic tools pointed out that, but that were not obviously or clear-cut safe (e.g. adding spaces after comma, in `subst` or similar situations) were reverted before I pushed. I chose to err on the "First, do no harm" side, so there might be places that could have been corrected, but were not. 
> 
> I have made a single type of change per commit in this branch. It might be easier to review this by looking at one commit at a time.

This pull request has now been integrated.

Changeset: 66945e50
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/66945e501049de3a1e1d73303928af87190ae33c
Stats:     634 lines in 81 files changed: 27 ins; 10 del; 597 mod

8339336: Fix build system whitespace to adhere to coding conventions

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/jdk/pull/20798


More information about the build-dev mailing list