RFR: 8339714: Delete tedious bool type define
SendaoYan
syan at openjdk.org
Mon Sep 9 12:53:06 UTC 2024
On Mon, 9 Sep 2024 12:06:25 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Hi all,
>> This PR delete tedious bool type define in `src/java.base/unix/native/libjsig/jsig.c` and `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we can "#include <stdbool.h>" to use bool type directly, like [string.h](https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/native/libpipewire/include/spa/utils/string.h#L13) do.
>> Make code more concision, the risk is quite low.
>>
>> Additional testing:
>>
>> - [x] Local build with --with-hsdis=binutils --with-binutils=$HOME/software/binutils
>> - [ ] Jtreg tests(include tier1/tier2/tier3 etc.) on linux x64
>> - [ ] Jtreg tests(include tier1/tier2/tier3 etc.) on linux aarch64
>
> src/java.base/unix/native/libjsig/jsig.c line 46:
>
>> 44: #include <string.h>
>> 45:
>> 46: #if (__STDC_VERSION__ >= 199901L)
>
> Since this does include stdbool.h already, this change looks ok
Okey.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20909#discussion_r1750201356
More information about the build-dev
mailing list