RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]
Daniel Jeliński
djelinski at openjdk.org
Tue Sep 10 15:18:09 UTC 2024
On Tue, 10 Sep 2024 13:30:05 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>>
>>> 69: -framework Foundation \
>>> 70: -framework SystemConfiguration, \
>>> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib version.lib ws2_32.lib, \
>>
>> Can the libs added here be removed from libnio dependencies now? mswsock.lib appears to be unused by libnio, not sure about other platforms.
>
> I believe this question has already been answered [here](https://github.com/openjdk/jdk/pull/20317/files#r1707599113).
well I'm not satisfied with the answers :) I removed mswsock.lib from libnio dependencies [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89) and the build still passed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1752181579
More information about the build-dev
mailing list