RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

Brian Burkhalter bpb at openjdk.org
Wed Sep 11 19:25:07 UTC 2024


On Tue, 10 Sep 2024 11:27:05 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8337143: Remove loading libnet from Inet6AddressImpl; delete commented out #include in Windows IOUtil.c
>
> src/java.base/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java line 1097:
> 
>> 1095: 
>> 1096:     static {
>> 1097:         jdk.internal.loader.BootLoader.loadLibrary("net");
> 
> ...do we still need net here?

We don't need it in `libjava`, but `NTLMAuthentication` was (perhaps unwittingly) relying on it to load `net.dll` during boot phase 2. I'll move the load to a more appropriate location in the next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755440401


More information about the build-dev mailing list