RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

[Brian Burkhalter]

On Tue, 10 Sep 2024 09:54:56 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8337143: Remove loading libnet from Inet6AddressImpl; delete commented out #include in Windows IOUtil.c
>
> make/modules/java.base/Lib.gmk line 48:
> 
>> 46:     OPTIMIZATION := LOW, \
>> 47:     EXTRA_HEADER_DIRS := \
>> 48:         libjava/nio/ch, \
> 
> This appears to be unneeded

Agreed. See 853d349.

> src/java.base/unix/classes/sun/nio/ch/NativeThread.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> No changes in this file

There is one now. 853d349

> src/java.base/unix/native/libnio/ch/NIOUtil.c line 34:
> 
>> 32: #include "jvm.h"
>> 33: #include "jlong.h"
>> 34: #include "sun_nio_ch_IOUtil.h"
> 
> should this be NIOUtil?

Yes. See 853d349.

> src/java.base/windows/native/libnio/ch/NIOUtil.c line 41:
> 
>> 39: 
>> 40: JNIEXPORT jboolean JNICALL
>> 41: Java_sun_security_provider_NativeSeedGenerator_nativeGenerateSeed
> 
> unused

Removed. 853d349

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755983126
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755984164
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755984274
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755985066