RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v7]

Daniel Jeliński djelinski at openjdk.org
Thu Sep 12 06:27:09 UTC 2024


On Thu, 12 Sep 2024 02:10:00 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8337143: Clean up to address reviewer comments

Thanks for making the changes. LGTM, assuming that tests still pass.

One question in line.

src/java.base/unix/native/libjava/nio/fs/UnixNativeDispatcher.c line 221:

> 219: static futimesat_func* my_futimesat_func = NULL;
> 220: static futimens_func* my_futimens_func = NULL;
> 221: #ifndef _ALLBSD_SOURCE

This change looks unrelated. Was it intentional?

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20317#pullrequestreview-2299319884
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1756202839


More information about the build-dev mailing list