RFR: 8329816: Add SLEEF version 3.6.1 [v6]

Mikael Vidstedt mikael at openjdk.org
Mon Sep 16 17:30:21 UTC 2024


On Mon, 16 Sep 2024 10:30:46 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately.
>> 
>> This is a new attempt at solving [JDK-8329816](https://bugs.openjdk.org/browse/JDK-8329816); the original attempt is here: https://github.com/openjdk/jdk/pull/19185. This PR is based on the discussions on how to move forward that was held in that original PR.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update legal/sleef.md

make/UpdateSleefSource.gmk line 48:

> 46: 
> 47: ifeq ($(CMAKE), )
> 48:   $(error CMake not found. Please install cmake and rerun confugure)

typo -> configure

make/UpdateSleefSource.gmk line 132:

> 130: $(CROSS_COMPILATION_SRC_FILES): $(sleef_cross_build)
> 131: 
> 132: # Finally, copy the generated files (and one needed static files) into our

files -> file (or drop "one")

src/jdk.incubator.vector/linux/native/libsleef/README.md line 28:

> 26: To update the version of libsleef that is used in the JDK, clone
> 27: `https://github.com/shibatch/sleef.git`, and copy all files, except the `docs`
> 28: and `.github` directories, into

And, for completeness, `.git`

src/jdk.incubator.vector/linux/native/libsleef/README.md line 49:

> 47: 
> 48: Now, you can repeat this for the next platform. For instance, you can
> 49: create a separate profile using `configure --with-conf-name=riscv64` and then

profile -> configuration?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1761517507
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1761522889
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1761563950
PR Review Comment: https://git.openjdk.org/jdk/pull/20781#discussion_r1761530302


More information about the build-dev mailing list