RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF

[Erik Joelsson]

On Thu, 19 Sep 2024 13:47:50 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> make/modules/jdk.incubator.vector/Lib.gmk line 48:
>> 
>>> 46:       DISABLED_WARNINGS_gcc := unused-function sign-compare tautological-compare ignored-qualifiers, \
>>> 47:       DISABLED_WARNINGS_clang := unused-function sign-compare tautological-compare ignored-qualifiers, \
>>> 48:       CFLAGS := $(CFLAGS_JDKLIB) -O3 -march=rv64gcv, \
>> 
>> I think we prefer using the `C_O_FLAG_*` variables instead of explicitly specifying `-O3`.
>
> Thanks, do you mean something like below? I'll fix it.
> 
> CFLAGS := $(CFLAGS_JDKLIB) $(C_O_FLAG_HI) -march=rv64gcv, \

Sorry, I had to remind myself of how this works. We actually set this as a separate parameter on the Setup macro: `OPTIMIZATION := HIGH`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1767100590