RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v4]

Hamlin Li mli at openjdk.org
Tue Sep 24 14:56:32 UTC 2024


On Tue, 24 Sep 2024 03:47:41 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine comment
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 6063:
> 
>> 6061: 
>> 6062:   void generate_vector_math_stubs() {
>> 6063:     if (UseRVV) {
> 
> Seems to me cleaner to do this:
> 
> if (UseRVV) {
>   generate_vector_math_stubs();
> }

As there are several log output in the method, I think it might be better to put them together in this method.

But I made some modification so the indentation looks better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1773531189


More information about the build-dev mailing list