RFR: 8340804: doc/building.md update Xcode instructions to note that full install is required [v2]

Erik Joelsson erikj at openjdk.org
Tue Sep 24 15:30:36 UTC 2024


On Tue, 24 Sep 2024 13:08:50 GMT, George Adams <gdams at openjdk.org> wrote:

>> Since JDK17 there has been a dependency on metal in the macOS builds which is only available as part of the full Xcode IDE (rather than command-line tools). We currently recommend only installing the command-line tools in the building.md doc which is incorrect.
>> 
>> See https://github.com/openjdk/jdk/blob/e1c4d3039f6b5106ce3f65d50f607eacc2a8d168/make/autoconf/toolchain.m4#L681
>
> George Adams has updated the pull request incrementally with one additional commit since the last revision:
> 
>   run pandoc

doc/building.md line 426:

> 424: 
> 425: You will need to download Xcode either from the App Store or specific versions
> 426: can be easily located via the [Xcode Releases](https://xcodereleases.com) website.

This file is trying to keep a consistent 80 char line length limit and this line is longer than 80.
Suggestion:

can be easily located via the [Xcode Releases](https://xcodereleases.com)
website.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21154#discussion_r1773591622


More information about the build-dev mailing list