RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v8]

Hamlin Li mli at openjdk.org
Mon Sep 30 09:36:36 UTC 2024


On Mon, 30 Sep 2024 09:01:24 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix test macro
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 2044:
> 
>> 2042:   }
>> 2043: 
>> 2044:   if (addr == nullptr && Matcher::supports_scalable_vector()) {
> 
> Shouldn't this be in the `default` branch of the switch above? Otherwise, we would be hitting the `Unimplemented();` at https://github.com/openjdk/jdk/pull/21083/files#diff-33d0866101d899687e04303fb2232574f2cb796ce060528a243ebdc9903b01b1R2040?

Do you mean when the bits > 512, e.g. 1024?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1780753333


More information about the build-dev mailing list