RFR: 8353217: Build libsleef on macos-aarch64 [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Apr 1 21:09:17 UTC 2025
On Tue, 1 Apr 2025 19:59:20 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Build and use SLEEF library as a backend implementation for Vector API trigonometric functions on macosx-aarch64 platform.
>>
>> It improves raw throughput and eliminates GC overhead of non-intrinsified Vector API operation.
>>
>> PR includes build changes and libsleef sources relocation from `src/jdk.incubator.vector/linux/native/` to `src/jdk.incubator.vector/share/native/`.
>>
>> Once libsleef library is present, existing code in `stubGenerator_aarch64.cpp` successfully links at JVM startup.
>>
>> Testing: hs-tier1 - hs-tier4, microbenchmarks
>
> Vladimir Ivanov has updated the pull request incrementally with two additional commits since the last revision:
>
> - Build changes
> - share/native -> unix/native
LGTM now. Thanks! I sauggest awaiting another build group reviewer since I wrote some of this code.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24306#pullrequestreview-2734048599
More information about the build-dev
mailing list