RFR: 8301197: Make sure use of printf is correct and actually needed

David Holmes dholmes at openjdk.org
Fri Apr 4 02:25:51 UTC 2025


On Thu, 3 Apr 2025 21:07:50 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/Docs.gmk line 267:
>> 
>>> 265: 	$$(call LogInfo, Creating overview.html for $1)
>>> 266: 	$$(call MakeDir, $$(@D))
>>> 267: 	$$(PRINTF) "%s" '$$($1_OVERVIEW_TEXT)' > $$@
>> 
>> For my education, why isn't this just `$$(ECHO) '$$($1_OVERVIEW_TEXT)' > $$@` ?
>
> That would add an extra \n at the end. Maybe it does not matter so much, but I did not want to change anything.

`echo -n` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24415#discussion_r2027989940


More information about the build-dev mailing list