RFR: 8301197: Make sure use of printf is correct and actually needed [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Apr 4 14:32:30 UTC 2025
> We have been sloppy in our use of `printf` in make code. Most of the time, we should really use `echo` instead. If we do need to use `printf`, we should never inline make or shell variables into the formatting string, since they may contain `%` which will be interpreted as formatting. Instead, we should always use `%s` and pass the variable as an argument to `printf`.
>
> I've checked the entire code base for usages of $PRINTF, and converted most of them to $ECHO, and made sure the remaining ones are correct. I also discovered some additional ugly stuff in relation to this, which I fixed.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
echo do not need escaped quotes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24415/files
- new: https://git.openjdk.org/jdk/pull/24415/files/db4cdc8a..a1b16a75
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24415&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24415&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24415.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24415/head:pull/24415
PR: https://git.openjdk.org/jdk/pull/24415
More information about the build-dev
mailing list