RFR: 8300339: Run jtreg in the work dir [v3]

Magnus Ihse Bursie ihse at openjdk.org
Tue Apr 8 14:31:38 UTC 2025


On Mon, 7 Apr 2025 20:33:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/RunTests.gmk line 1000:
>> 
>>> 998:   $1_COMMAND_LINE := \
>>> 999:       cd $$($1_TEST_SUPPORT_DIR) && $$(JTREG_JAVA) \
>>> 1000:       $$($1_JTREG_LAUNCHER_OPTIONS) \
>> 
>> Should this be aligned with the row below?
>
> I didn't notice that. Actually, I think it is the remaining lines that are incorrectly indented.

With some more context, I see that the original author tried to separate the jtreg arguments from the additional structure needing to execute things properly in make. I made this more explicit by extracting the arguments to a separate variable, which led to more natural indentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24452#discussion_r2033331769


More information about the build-dev mailing list