RFR: 8354213: Restore pointless unicode characters to ASCII [v3]
Naoto Sato
naoto at openjdk.org
Wed Apr 9 17:24:43 UTC 2025
On Wed, 9 Apr 2025 15:53:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> I believe the source code of the JDK should be in US-ASCII if possible, and only employ extended characters if that is strictly necessary for the code to work.
>>
>> In my attempt to figure out which non-ascii files are another encoding than utf-8 (see [JDK-8301971](https://bugs.openjdk.org/browse/JDK-8301971)), I discovered a handful of files that use unicode characters for no good reason, when normal ASCII characters could have been used (and have been used everywhere else in the code base in similar contexts).
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Oops.
Looks good to me. I was just expecting the usual suspects, such as, apostrophe/hyphen-minus variations in comments, but never expected zero-width space, or Cyrillic "C" in place for ascii "C" in the code!
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24552#pullrequestreview-2754211738
More information about the build-dev
mailing list