RFR: 8354510: Skipped gtest cause test failure

Tue Apr 15 05:14:48 UTC 2025

On Mon, 14 Apr 2025 13:25:20 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> `GTEST_SKIPPED` tests count is accounted in gtests run. But when we calculate the number of GTEST errors we take `ERROR = RUN - PASSED - FAILED`. We need parse and account for the skipped as well. Currently we only account for `DISABLED` gtests (which are not counted as run tests). 
> 
> This patch adds support for both `DISABLED` and `GTEST_SKIPPED` tests.
> 
> So with this patch we end up with: 
> `ERROR = RUN - PASSED - FAILED - GTEST_SKIPPED`
> `SKIPPED = GTEST_SKIPPED + GTEST_DISABLED `
> 
> Verified that this works locally on MacOS and Linux. Currently running through testing and GHA. 
> 
> _The old `match` expression was problematic with some awk, not sure if there was some other reason it was used, rather than the style used elsewhere `maybe set, if unset set=0`_

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24622#issuecomment-2803823273