RFR: 8301971: Make JDK source code UTF-8 [v3]
Matthias Baesken
mbaesken at openjdk.org
Wed Apr 16 10:37:42 UTC 2025
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This has recently become an acute problem, since our mixing of iso-8859-1 and utf-8 in properties files confused the version of `sed` that is shipped with the new macOS 15.4.
>>
>> The fix is basically simple, and includes the following steps:
>> * Look through the code base for text files containing non-ASCII characters, and convert them to UTF-8, if they are not already
>> * Update tooling used in building to recognize the fact that files are now in UTF-8 and treat them accordingly (basically, updating compiler flags, git attributes, etc).
>
> Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision:
>
> - Also document UTF-8 requirements (solves JDK-8338973)
> - Let configure only accept utf-8 locales
> - Address review comments from Kim
make/autoconf/basic.m4 line 155:
> 153: else
> 154: AC_MSG_RESULT([no UTF-8 locale found])
> 155: AC_MSG_ERROR([No UTF-8 locale found. This is required for building successfully.])
Seems we run into this 'else' part on AIX
checking for locale to use... no UTF-8 locale found
configure: error: No UTF-8 locale found. This is required for building successfully.
configure exiting with result code 1
maybe it would be nice to display the desired ones C.UTF-8 or en_US.UTF-8 in this message too for more clarity? (have to check if there are other names on AIX)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24574#discussion_r2046642699
More information about the build-dev
mailing list