RFR: 8345874: Run make doctor automatically on failed CI builds [v2]

SendaoYan syan at openjdk.org
Sun Apr 20 04:05:43 UTC 2025


On Wed, 9 Apr 2025 20:29:45 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> If there is something wrong with the build, the user can run "make doctor". That is hard to do in a CI setting. Instead, if the build environment is detected to be a CI, we should run the doctor automatically in case of a failed build.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into make-doctor-on-ci
>  - 8345874: Run make doctor automatically on failed CI builds

make/autoconf/spec.gmk.template line 173:

> 171: 
> 172: # dev or ci
> 173: BUILD_ENV := @BUILD_ENV@

I think the `BUILD_ENV` could be seted in command line also. So, should we update the doc/building.md sync with this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24485#discussion_r2051629135


More information about the build-dev mailing list