RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

[Chen Liang]

On Tue, 22 Apr 2025 08:03:30 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify FFM linker warmup
>
> src/java.base/share/classes/jdk/internal/foreign/abi/LinkerOptions.java line 149:
> 
>> 147:         @Override
>> 148:         public boolean equals(Object obj) {
>> 149:             return obj instanceof FirstVariadicArg that && index == that.index;
> 
> Might be worth checking `obj == this || obj instanceof ...`

I think this is still unlikely to hit (it is possible if people intentionally reuse the value of a `Linker.Option.firstVariadicArg` call), most of the usages will see non-identity equality comparisons.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24742#discussion_r2054306216