RFR: 8355003: Implement Ahead-of-Time Method Profiling

[Vladimir Kozlov]

On Sun, 27 Apr 2025 00:24:31 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> src/hotspot/share/ci/ciInstanceKlass.hpp line 47:
>> 
>>> 45:   friend class ciField;
>>> 46:   friend class ciReplay;
>>> 47:   friend class CompileTrainingData;
>> 
>> Not referenced here
>
> It allows `CompileTrainingData` to peek into the `ciInstanceKlass` internals. We need the klass ptr specially.

I missed that it is "friend" declaration.

>> src/hotspot/share/ci/ciMethodData.cpp line 71:
>> 
>>> 69: 
>>> 70:   bool is_live(Method* m) {
>>> 71:     Klass* holder = m->method_holder();
>> 
>> Changes in this file seems not related and can be pushed/tested separately. If they are related - there should be condition for additional checks.
>
> You mean you want these checks to be done only if `TrainingData::have_data() == true` ?

Yes, if it is related. Otherwise you may change default behavior when Leyden code is not used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2061910254
PR Review Comment: https://git.openjdk.org/jdk/pull/24886#discussion_r2061908809