RFR: 8355697: Create windows devkit on wsl and msys2 [v2]
Erik Joelsson
erikj at openjdk.org
Mon Apr 28 13:50:47 UTC 2025
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei <duke at openjdk.org> wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d "d:/VisualStuio"]` . The path must be converted as linux style before testing.
>> * In msys2, `cmd.exe /c` doesn't work because "/c" is converted as "c:", it can be work around with `cmd.exe //c`. see https://superuser.com/questions/526736/how-to-run-internal-cmd-command-from-the-msys-shell
>>
>> I tested it with win10 + wsl/msys2 + VisualStudio 2022(17.13.6)
>
> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>
> Get SDK_INSTALL_DIR from enviroment variable
Verified that it still works in Cygwin on my machine. Looks good.
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24916#pullrequestreview-2799371090
More information about the build-dev
mailing list