RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks
Magnus Ihse Bursie
ihse at openjdk.org
Mon Apr 28 20:35:45 UTC 2025
On Thu, 10 Apr 2025 12:02:45 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
> Avoid filtering out xml files at the root of the JMH folder, in order to get the `default.instruments.template.xml` file bundled in the JMH core jar to support xtrace profiler.
With that said, it is very much unclear why this line is here at all. The removal of xml files is from the original integration of microbenchmarks, JDK-8061281, and the reason behind it is lost in time.
But if this works, and does not break any existing microbenchmark tests, I don't see any problem.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24571#issuecomment-2836494237
More information about the build-dev
mailing list