RFR: 8355697: Create windows devkit on wsl and msys2 [v2]
kuaiwei
duke at openjdk.org
Tue Apr 29 03:38:34 UTC 2025
On Mon, 28 Apr 2025 19:30:23 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Get SDK_INSTALL_DIR from enviroment variable
>
> make/devkit/createWindowsDevkit.sh line 69:
>
>> 67: elif test "x$IS_MSYS" != "x"; then
>> 68: BUILD_ENV="cygwin"
>> 69: CMD_EXE="cmd.exe //c"
>
> The `//c` is a hacky solution.
>
> I think it would be better if you exported `MSYS2_ARG_CONV_EXCL="*"` -- you can do that without testing for windows environment since it does not really matter on anything but msys.
>
> Then you can skip `CMD_EXE` and keep the single-slash variant for all environments.
Thanks for your comments. I added `MSYS2_ARG_CONV_EXCL="*"` in script and tested with msys.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24916#discussion_r2065365968
More information about the build-dev
mailing list