RFR: 8350209: Preserve adapters in AOT cache [v12]
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 30 23:58:48 UTC 2025
On Wed, 30 Apr 2025 22:22:18 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/code/relocInfo.hpp line 1292:
>
>> 1290: void pack_data_to(CodeSection * dest) override;
>> 1291: void unpack_data() override;
>> 1292: #if defined(AARCH64)
>
> It's unfortunate to see AArch64-specific code in shared code.
>
> But I don't see anything besides`pd_destination()` and `pd_set_destination()` declarations. Where're their bodies?
Good catch. I copied it from leyden/premain but it is used only for trampoline jump relocation for calls in nmethods on Aarch64. They are not present in adapters. I remove this code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2069677599
More information about the build-dev
mailing list