RFR: 8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once [v4]
Daniel Hu
duke at openjdk.org
Thu Aug 7 17:18:16 UTC 2025
On Wed, 9 Jul 2025 22:28:56 GMT, Daniel Hu <duke at openjdk.org> wrote:
>> These changes should prevent entire binary files from being loaded into memory for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since BufferedInputStream uses that, but open to alternative solutions. GHA passes and test passes on linux x64.
>
> Daniel Hu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into 8341735
> - redid byte matching which should fix cross chunk strings
> - style improvements
> - remove 8341024
> - remove trailing whitespace
> - fix
I'll push another update soon to fix the speed issue
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26030#issuecomment-3165089009
More information about the build-dev
mailing list