RFR: 8362243: Devkit creation for Fedora base OS is broken [v2]

Volkan Yazici vyazici at openjdk.org
Wed Aug 20 07:38:26 UTC 2025


On Wed, 20 Aug 2025 06:40:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Run `update-build-docs`
>>  - Revert `ppc64be` removal
>
> make/devkit/Tools.gmk line 76:
> 
>> 74:   endif
>> 75:   ifeq ($(ARCH), riscv64)
>> 76:     ifeq ($(filter 36 37, $(BASE_OS_VERSION)), )
> 
> The test and the error message does not match up.

Very sharp of you, thanks! 🙏 I should have used `ifneq`. I've replaced the current mind-bending expression with a simpler one in bdee4cae67c.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26821#discussion_r2287265983


More information about the build-dev mailing list