RFR: 8373388: Reenable LTO for libsplashscreen
Phil Race
prr at openjdk.org
Fri Dec 12 18:45:51 UTC 2025
On Wed, 10 Dec 2025 13:27:31 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> [JDK-8372554](https://bugs.openjdk.org/browse/JDK-8372554) disabled LTO for libsplashscreen to fix an issue with the comparison build. It turns out the failure was caused by extra files that LTO produced and which were included in the image. Now that [JDK-8373255](https://bugs.openjdk.org/browse/JDK-8373255) has fixed that we should be able to reenable LTO again.
Marked as reviewed by prr (Reviewer).
> > Why was it enabled in the first place ?
> If your question is about 'why for libsplashscreen' , because we see some good lib size - benefits for this lib (there were some measurements by @mserb for this [#27976 (comment)](https://github.com/openjdk/jdk/pull/27976#issuecomment-3568427441) ) .
Yes, my question was why splash screen out of all the libraries in the JDK.
I guess a size reduction is good, but I've no idea if it helps performance.
Note that on Linux, IIRC, the system gif/png/jpeg libs may be used by the build, and in such a case
I doubt there's much "size" left to reduce.
I've re-tested the comparison build and it passed. So I'll approve, just for this one library.
-------------
PR Review: https://git.openjdk.org/jdk/pull/28746#pullrequestreview-3573133409
PR Comment: https://git.openjdk.org/jdk/pull/28746#issuecomment-3647698972
More information about the build-dev
mailing list